Injectpaymentonion #7749
Merged
Injectpaymentonion #7749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdecker
approved these changes
Oct 18, 2024
Contributor
Author
|
Trivial master rebase, and tests are now split properly (final fixup commit). If this is OK, I'll fold and apply. |
rustyrussell
force-pushed
the
injectpaymentonion
branch
2 times, most recently
from
fee3cf8 to
5727b79
Compare
This makes it slightly more generic. Signed-off-by: Rusty Russell <[email protected]>
…r_unknown_payment_details This message is supposed to include the msat amount received. But this is obviously per-HTLC, and we hacked it to use the value for the first one. And we add logging whenever we fail an HTLC set, since we removed logging by not calling failmsg_incorrect_or_unknown() (which, now, no longer needs to log). Signed-off-by: Rusty Russell <[email protected]>
Make it a set of arbitrary data, so we can use it for local payments, not just HTLCs. Signed-off-by: Rusty Russell <[email protected]>
…tpaymentonion. Rather than assuming the callbacks, make them function pointers. Signed-off-by: Rusty Russell <[email protected]>
Put these in utils and make them a bit more powerful, so we can use them elsewhere. Signed-off-by: Rusty Russell <[email protected]>
Don't assume we have an outgoing HTLC at this level. Note that previously we didn't save the failed onion unless it was unparsable: we keep that both for space savings and because our `waitsendpay` logic assumes that when it fetches from the db if there's a failonion it was unparsable! Signed-off-by: Rusty Russell <[email protected]>
This is like `sendonion` but unwraps the onion as the first hop, avoiding nasty special cases for blinded paths which start with this node, and also self-pay. Tests split into multiple ones after Christian's review. Changelog-Added: JSON-RPC: `injectpaymentonion` for initiating an HTLC like a peer would do. Signed-off-by: Rusty Russell <[email protected]>
rustyrussell
force-pushed
the
injectpaymentonion
branch
from
5727b79 to
130eac7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new RPC, improving on
sendonion, which takes the same path as an onion coming in an HTLC from a peer. This vastly simplifies handling cases like blinded paths which start at this peer, and self-pay: both are handled automatically.In addition, the call simply blocks, rather than requiring another call to receive the results.